beyond-all-reason / beyond-all-reason/RecoilEngine
SetProjectileTarget targettype `g` is not necessary
Open
good first issue
refactor
- Dominant language
- C++
- Stars
- 679
- Forks
- 290
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 38
Description
See https://github.com/beyond-all-reason/RecoilEngine/blob/9edb166/rts/Lua/LuaSyncedCtrl.cpp#L5241
This line can be safely removed. Effectively same thing as passing invalid targettype
Contributor guide
Research direction
Open rts/Lua/LuaSyncedCtrl.cpp at line 5241 and read the SetProjectileTarget targettype handling around that line. Remove the unnecessary `g` case and verify that its behavior remains equivalent to passing an invalid targettype.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100