beyond-all-reason / beyond-all-reason/RecoilEngine

Add CMDTYPEs for dealing with features

Open
#2,177 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

The only `CMDTYPE` that can take features as an argument is `ICON_UNIT_FEATURE_OR_AREA`. This is a problem for skyrbunny, who wants to make Warcraft 3-style items, and is thinking of making the items be features. We should have everything for features that we have for units. So `ICON_FEATURE`, `ICON_FEATURE_OR_MAP`, `ICON_FEATURE_OR_AREA`, and (I suppose), `ICON_FEATURE_OR_RECTANGLE`.

Just look at how inbuilt resurrect is implemented, a command that should be `ICON_FEATURE_OR_AREA`:
![Image](https://github.com/user-attachments/assets/9b18cc36-06a4-4479-960f-dd4137c4c91a)

Contributor guide

Open the contributing guide

Research direction

Start by locating the CMDTYPE definitions and the inbuilt resurrect command mentioned in the issue. Compare the existing unit feature-related command types, then add the requested feature variants: ICON_FEATURE, ICON_FEATURE_OR_MAP, ICON_FEATURE_OR_AREA, and ICON_FEATURE_OR_RECTANGLE. Done means feature-based items can use the same command coverage as units.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.