beyond-all-reason / beyond-all-reason/RecoilEngine
Improve SetMoveType error messages
- Dominant language
- C++
- Stars
- 679
- Forks
- 290
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
https://github.com/beyond-all-reason/RecoilEngine/blob/b70976ab63af3df0de4a9f522cd3f95df918444a/rts/Lua/LuaSyncedMoveCtrl.cpp#L766-L770
This says "incompatible movetype key for %s" but actually it can also fail if something is wrong with the value, most commonly if you have a good key but pass nil.
Contributor guide
Research direction
Start at rts/Lua/LuaSyncedMoveCtrl.cpp lines 766-770 and inspect how SetMoveType reports failures for the key and value. Update the error wording so it distinguishes an incompatible key from an invalid value such as nil, then run the relevant existing tests or checks for Lua move control if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100