beyond-all-reason / beyond-all-reason/RecoilEngine

Consider putting OS-specific platform stuff in OS subfolders

Open
#1,949 0 comments 0 reactions 0 assignees View on GitHub
good first issue refactor
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Files directly within [Platform](https://github.com/beyond-all-reason/spring/blob/master/rts/System/Platform/) sometimes contain inline OS checks like `#ifdef _WIN32`, perhaps move some of these to the appropriate subfolders (e.g. [Platform/Win](https://github.com/beyond-all-reason/spring/tree/master/rts/System/Platform/Win))?

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the files directly inside rts/System/Platform/ and comparing them with the OS-specific folders, especially rts/System/Platform/Win/. Search for inline _WIN32 checks and determine which platform-specific code is suitable for relocation. Done means the appropriate OS-specific logic is organized in the relevant subfolders without changing cross-platform behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.