beyond-all-reason / beyond-all-reason/RecoilEngine

Consider applying armor to all damage

Open
#1,804 0 comments 0 reactions 0 assignees View on GitHub
game compat
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Right now armor is not applied to collision damage. This leads to surprising behaviour where units can still get damaged despite setting the multiplier to 0. I don't expect any game would mind since collision damage is very rare (ZK involves lots but we override it in a gadget anyway) but it would be good to ask beforehand.
https://github.com/beyond-all-reason/RecoilEngine/blob/7363dbc54b55d309539b92c60245f88afd1f4e4a/rts/Sim/Units/Unit.cpp#L1298-L1306

Contributor guide

Open the contributing guide

Research direction

Start in rts/Sim/Units/Unit.cpp at lines 1298-1306 and trace how collision damage is handled compared with other damage types. Check the relevant damage behavior and confirm that collision damage respects the configured armor multiplier, including a multiplier of 0.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.