beyond-all-reason / beyond-all-reason/RecoilEngine
Check AI interfaces for UnitDestroyed change
Open
Nobody has claimed this yet.
refactor
- Dominant language
- C++
- Stars
- 683
- Forks
- 293
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
See my unaddressed comment at https://github.com/beyond-all-reason/spring/pull/1669#discussion_r1739747047
- if existing AIs (Circuit/Barbarian, etc) use the event, then won't they fail to build due to different function signature?
- if they build correctly then was the correct function even modified?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the UnitDestroyed change discussed in pull request 1669 and inspect the existing AI interfaces, including Circuit and Barbarian, that use this event. Build those interfaces and compare their function signatures with the modified declaration; done means all affected AIs build correctly and the intended signature change is confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100