beyond-all-reason / beyond-all-reason/RecoilEngine

`resources.lua` is parsed 3 times over apparently

Open
#1,703 0 comments 1 reaction 0 assignees View on GitHub
refactor
Dominant language
C++
Stars
683
Forks
293
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Do it just once.
https://github.com/beyond-all-reason/RecoilEngine/blob/036c815e405121135437870421fee77c7fb218f3/rts/Rendering/Env/Particles/ProjectileDrawer.cpp#L92
https://github.com/beyond-all-reason/RecoilEngine/blob/036c815e405121135437870421fee77c7fb218f3/rts/Map/MapInfo.cpp#L55
https://github.com/beyond-all-reason/RecoilEngine/blob/036c815e405121135437870421fee77c7fb218f3/rts/Rendering/Env/Decals/GroundDecalHandler.cpp#L254

Contributor guide

Open the contributing guide

Research direction

Start by reading the cited locations in rts/Rendering/Env/Particles/ProjectileDrawer.cpp, rts/Map/MapInfo.cpp, and rts/Rendering/Env/Decals/GroundDecalHandler.cpp to trace how resources.lua is parsed. Determine how the three consumers can share one parse result, then verify that resources.lua is parsed only once without breaking those consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.