beyond-all-reason / beyond-all-reason/RecoilEngine
Fix sampling for mingw builds
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 683
- Forks
- 293
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
I think #1385 is a very crude solution to the wider problem where tracy zones are just hardcoded arbitrarily, and testers aren't C++ coders so they can't easily add further instrumentation. If a function takes 999ms but its subfunctions have no zones so it appears as a single blob in tracy, what can you do? The answer should probably not be "run a bigass text replace that uncomments a billion redundant tracy zones" as #1385 would like but ideally it would not be the current answer of "lol. lmao" either.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by comparing the MinGW sampling behavior with the concerns raised about #1385, then identify the relevant sampling and Tracy instrumentation code; done should mean MinGW builds provide useful sampling without requiring broad, manual zone uncommenting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- observability, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100