beyond-all-reason / beyond-all-reason/RecoilEngine

Improve handling corrupted files (Error: [PoolArchive::GetFileImpl] failed to read file)

Open
#1,283 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Sometimes we have a problem when files got corrupt. And this occured problem remain until user manually read own log and delete that file so it's got redownloaded.

There's confirmed cases that it's leads to desyncs.

Contributor guide

Open the contributing guide

Research direction

Start at PoolArchive::GetFileImpl and investigate the corrupted-file read path described in the issue. Reproduce the failure if possible; done should mean corrupted files are handled without requiring manual log inspection and deletion, and confirmed cases no longer cause desyncs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.