beyond-all-reason / beyond-all-reason/RecoilEngine
CMD_LOAD_ONTO doesn't maintain the transport's half of the order
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 683
- Forks
- 293
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
### Repro
1) ZK, `/give gunshiptrans`, `/give cloakraid`.
2) select the cloakraid and rightclick the gunshiptrans. This gives the cloakraid a CMD_LOAD_ONTO command, which doesn't involve any loading on its own. Rather, it inserts a CMD_LOAD_UNITS command in front of the transport's queue with the cloakraid as the command target.
3) cancel the transport's CMD_LOAD_UNITS. For example give a Stop command. Note that this can happen for a variety of reasons (misclick, automation widget interferes, etc).
### Current behaviour
The cloakraid waits forever to get picked up, which never happens.
### Expected behaviour
Either transport picks up the unit eventually OR the unit's load-onto command is dropped.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the ZK scenario with a cloakraid and gunshiptrans, then trace the CMD_LOAD_ONTO and transport-side CMD_LOAD_UNITS handling. Check what happens when the transport command is cancelled; done means the cloakraid is eventually picked up or its load-onto command is dropped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100