beyond-all-reason / beyond-all-reason/RecoilEngine

Put armor in unit defs (and eventually deprecate armordefs)

Open
#1,239 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
C++
Stars
683
Forks
293
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Shield armor is already in the weapon def.

One argument against that I've seen is that the current format lets you have an explicit listing of units with given armor type but you can keep that and use it in posts to populate unit defs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing weapon definitions, unit definitions, and armordefs references mentioned in the issue, then trace how the explicit unit listings are used in posts. No files, tests, or entry points are identified, so the intended migration and deprecation boundary need to be agreed before implementation. Done should include a documented acceptance check for the new definition format and the remaining armordefs usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.