beyond-all-reason / beyond-all-reason/RecoilEngine

Remove char* array backed mem placeholders with magic size constants

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
refactor
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

The engine has tons of stuff like:
`uint8_t amtMemBuffer[512];`

This is very volatile and tedious to maintain. The magic number should either be replaced with sizeof() of object it gets size from or reworked to not have mem placeholders at all.

Contributor guide

Open the contributing guide

Research direction

Start by searching the engine for char* or uint8_t arrays using fixed sizes such as amtMemBuffer[512]. Review each placeholder's allocation and the object or buffer size it represents before deciding whether sizeof() is applicable or the placeholder can be removed. Done means the targeted magic-size placeholders are replaced or eliminated without changing engine behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.