bevyengine / bevyengine/bevy

Make MAX_DIRECTIONAL_LIGHTS a runtime value

Open
#8,992 2 comments 1 reaction 0 assignees View on GitHub
A-Rendering C-Usability D-Straightforward S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

## What problem does this solve or what need does it fill?

Currently `MAX_DIRECTIONAL_LIGHTS` is const, which prevents us from setting it to platform-specific (detected at runtime) values. For example, we need to set it to `1` for Adreno GPUs on WebGL. Currently, we are hard coding the value to `1` on WebGL for all GPUs, which is unnecessary.

## What solution would you like?

Make it a dynamic value set and read at runtime.

See #8505 for more information.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.