bevyengine / bevyengine/bevy

HSLA valid range discussion

Open
#7,095 4 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Docs
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

[bevy::prelude::Color::Hsla::lightness](https://docs.rs/bevy/latest/bevy/prelude/enum.Color.html#variant.Hsla.field.lightness)

The docs say that the valid range is [0, 1]. However, when it comes to HDR rendering, lightness > 1.0 can be used to make a color more bright, and is useful for instance with bloom.

Should we change the docs? Introduce a separate "brightness" field to sprites or something? What's the right solution?

Thanks to a user on discord for pointing this out :)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.