bevyengine / bevyengine/bevy

Use the freshly stabilized f32::total_cmp methods

Open
#5,152 7 comments 2 reactions 0 assignees View on GitHub
A-Math A-Rendering C-Code-Quality D-Trivial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

The [FloatOrd](https://github.com/bevyengine/bevy/blob/f1aae380ab165605cf5b197a9020eb42deca594b/crates/bevy_utils/src/float_ord.rs) type exists to workaround the inability to order Rust floats.

Fortunately, [the f32::total_cmp](https://doc.rust-lang.org/stable/std/primitive.f32.html#method.total_cmp) method [just stabilized](https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html).

We should at least use this internally, and investigate whether we can remove this wrapper type completely.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.