bevyengine / bevyengine/bevy

Replace f64-based types with f32-based types inside pan_orbit_camera

Open
#25,470 2 comments 0 reactions 0 assignees View on GitHub
A-Camera A-Editor C-Code-Quality S-Needs-Design X-Contentious
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

Sub-issue of #19741

Original upstream version of [`pan_orbit_camera`](https://github.com/bevyengine/bevy/tree/main/crates/bevy_camera_controller/src/pan_orbit_camera) had support for custom transforms(e.g. f64-based).
As we are not going to special-case support for non-``GlobalTransform`` transforms, f32-based types would be fully sufficient for Bevy's needs.

## Additional context

Further discussions are welcome in [#editor-dev](https://discord.com/channels/691052431525675048/789987800014651412)

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the pan_orbit_camera implementation in crates/bevy_camera_controller/src/pan_orbit_camera, linked from the issue. Identify the f64-based types used there and replace them with f32-based types, then verify that the camera controller still builds and behaves consistently with Bevy's GlobalTransform usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.