bevyengine / bevyengine/bevy

Update helper functions to use `FeathersNumberInput` modulus feature

Open
#25,280 1 comment 0 reactions 0 assignees View on GitHub
A-UI C-Feature S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## What problem does this solve or what need does it fill?

- Reference: #25265

> We should also figure out which examples could benefit from this feature: Search for HardLimit and PI :)

_Originally posted by @viridia in https://github.com/bevyengine/bevy/pull/25265#issuecomment-5159186448_

## What solution would you like?
- For example, I think we can improve helper functions such as `number_input_f32.rs` and `number_input_i32.rs` by adding `wrap` to their arguments.

https://github.com/bevyengine/bevy/blob/45653c586a1863bd0dad66b64b2a9cdd3c8be199/examples/helpers/number_input_f32.rs#L20-L26

- Through this change, we can also improve features like decal rotation in `clustered_decals.rs`.

Contributor guide

Open the contributing guide

Research direction

Start with examples/helpers/number_input_f32.rs and number_input_i32.rs, then inspect the FeathersNumberInput modulus feature from reference #25265. Search the examples for HardLimit and PI, including clustered_decals.rs, and identify inputs that would benefit from wrapping. Done means the helper arguments and applicable examples use the feature consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.