bevyengine / bevyengine/bevy

Remake PR #23567: CompressedImageSaver revamp

Open
#24,130 0 comments 0 reactions 0 assignees View on GitHub
A-Assets A-Rendering C-Feature D-Modest S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

>for now I have merged the textures into this branch, but before merging we should place them in the bevy asset repo

I think this is merged too quickly. The assets have not moved to bevy asset repo. Even if we delete these files later, the git history is permanently bloated unless you force push to rewrite history.

_Originally posted by @beicause in https://github.com/bevyengine/bevy/issues/23567#issuecomment-4368441340_

This PR was force-reverted due to the accidental inclusion of large asset files. @mockersf also reports that it broke (or at least changed) parallax mapping: https://discord.com/channels/691052431525675048/1500880505959092345/1500969107078778960

Contributor guide

Open the contributing guide

Research direction

The issue describes remaking the CompressedImageSaver work after a force-revert. Start by reviewing PR #23567 and the linked discussion, then identify how the textures should be moved to the Bevy asset repository and whether parallax mapping behavior changed. Done means the large assets are no longer included in Bevy history and the reported mapping behavior is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.