bevyengine / bevyengine/bevy

Replace uses of `BundleScratch` in the cloning code with `BundleWriter`

Open
#23,836 0 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Performance D-Complex D-Unsafe S-Ready-For-Implementation X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

@chescock in https://github.com/bevyengine/bevy/pull/23808#discussion_r3093246344_ says:

If I'm reading this correctly, the only difference between `BundleWriter` and `BundleScratch` is that `BundleScratch` stores the `Bump` externally so it can rely on lifetimes a bit more for safety. Is that right? Will we want to do follow-up work to replace the uses of `BundleScratch` in the cloning code with `BundleWriter`?

Contributor guide

Open the contributing guide

Research direction

Start by locating the cloning code that uses BundleScratch and read the BundleWriter and BundleScratch definitions, then review the discussion in PR #23808. Confirm whether the lifetime and external Bump distinction affects the replacement, and consider the work complete when the cloning code consistently uses BundleWriter without changing its behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.