bevyengine / bevyengine/bevy

Automatically infer ktx2 srgb-ness

Open
#23,693 0 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Feature C-Usability D-Straightforward S-Ready-For-Implementation X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

## What problem does this solve or what need does it fill?

`ktx2::Format` already specfies whether it's srgb formats (and KHR_DF_TRANSFER_SRGB for basis universal texture's srgb-ness). So it's not necessary to specify `is_srgb` in `ImageLoaderSettings` when loading ktx2 files. Manually setting `is_srgb` is also error-prone.

## What solution would you like?

Split `Ktx2Loader` and `Ktx2LoaderSettings` from `ImageLoader`, and make `is_srgb` optional in `Ktx2LoaderSettings`.

## What alternative(s) have you considered?

Manually set `is_srgb` when needed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.