bevyengine / bevyengine/bevy

feature-gated `System::refresh_hotpatch` with no default impl is inconvenient for crate authors

Open
#23,653 1 comment 0 reactions 0 assignees View on GitHub
A-Dev-Tools A-ECS C-Bug D-Straightforward S-Ready-For-Implementation X-Contentious
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

When the user uses the `hotpatching` feature, the `System` trait has one additional method, [`refresh_hotpatch`](https://dev-docs.bevy.org/bevy/ecs/prelude/trait.System.html#tymethod.refresh_hotpatch).

However, this method has no default impl. This means that other 3rd party crates the user relies on need to offer that feature too if these manually implement `System`, even if hotpatching makes no sense for them. If they don't do this, the user's project wont compile.

A solution could be to add an empty body as the default impl.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.