bevyengine / bevyengine/bevy

Investigate possible dead code in `handle_uncovered_swap_chains`

Open
#23,292 3 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Code-Quality D-Straightforward S-Needs-Testing X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

This seems to make sense, although we have code in the camera driver render graph system that attempts to handle the case where we acquire but do no work on a swapchain. See `handle_uncovered_swap_chains`. In theory, with this change, that code path is no longer necessary? (NB: Reading the code, I remember we used to have code that handled the case where you do have a camera but did no work, I think that is now handled by `view_target.needs_present` which tracks whether we ever did work on a view target).

If so, we should remove the `handle_uncovered_swap_chains` system.

_Originally posted by @tychedelia in https://github.com/bevyengine/bevy/pull/23276#pullrequestreview-3919432498_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.