bevyengine / bevyengine/bevy

DynamicBundle::Effect is now (almost) vestigial

Open
#20,979 0 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Code-Quality D-Modest S-Ready-For-Implementation X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

Does it still make sense to have `Effect` as an associated type here? It doesn't seem like it actually gets used, apart from the `NoBundleEffect` trait bound, which could be moved to `Self`. We should certainly leave it there for now to make this change smaller, but we may want to remove it as a follow up.

_Originally posted by @chescock in https://github.com/bevyengine/bevy/pull/20772#discussion_r2342573330_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.