bevyengine / bevyengine/bevy

`PluginGroupBuilder` needs methods that do not take `self`

Open
#20,938 2 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Feature C-Usability S-Needs-Design
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## What problem does this solve or what need does it fill?

If you have a plugin that is behind a feature, you can't add it to a plugin group because gating an attribution behind a cfg is experimental
```rust
#[cfg(feature = "a")]
builder = builder.add(MyPlugin); // This is experimental
```

## What solution would you like?

Have variants of the methods that take `&mut self` instead

## What alternative(s) have you considered?

* Adding the gated plugin outside of the `PluginGroupBuilder`
* Some other ugly workaround

Contributor guide

Open the contributing guide

Research direction

Start by locating `PluginGroupBuilder` and reading its existing builder methods and tests. Add equivalent `&mut self` variants that allow feature-gated plugins, then verify the relevant plugin-group tests cover the gated usage and pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.