bevyengine / bevyengine/bevy

TilemapChunkMeshCache in TilemapChunk is never used

Open
#20,908 0 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Bug S-Needs-Investigation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## Bevy version and features

- main

## What you did

- I was checking the new [TilemapChunk](https://github.com/bevyengine/bevy/blob/main/crates/bevy_sprite_render/src/tilemap_chunk/mod.rs#L48) source code and I noticed that the `TilemapChunkMeshCache` is never used.

https://github.com/bevyengine/bevy/blob/1faaf19c74ea2c030f9e5d9ec82e4ac9cb4ffa3d/crates/bevy_sprite_render/src/tilemap_chunk/mod.rs#L135-L140

## What went wrong

- Either add a new entry to the cache when there is a cache miss or remove the cache at all.

Contributor guide

Open the contributing guide

Research direction

Start by reading crates/bevy_sprite_render/src/tilemap_chunk/mod.rs around lines 135-140 and trace the uses of TilemapChunkMeshCache. The issue is done when the cache is either populated on a cache miss or removed entirely, with the chosen behavior consistent throughout the TilemapChunk implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.