bevyengine / bevyengine/bevy

Allow creating `Image` from `Color` for use in `EnvironmentMapLight`

Open
#20,443 0 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Usability D-Straightforward S-Needs-Design X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

#18207 deprecated `AmbientLight` in favor of `EnvironmentMapLight` but uses an awkward constructor that accepts a reference to the `Image` assets collection in addition to a color.

We should instead have something like `Image::from_color` or `Image::cubemap_from_color` that would accept a `Color` or a `ColorCurve` in order to produce the env map image. That way, the `EnvironmentMapLight` could just have a simple `from_image` constructor that feels more idiomatic.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.