bevyengine / bevyengine/bevy

Plugin infrastructure relies on type_name, despite non-uniqueness guarantees

Open
#20,128 8 comments 0 reactions 0 assignees View on GitHub
A-App C-Bug C-Code-Quality D-Straightforward S-Ready-For-Implementation X-Contentious
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

## What problem does this solve or what need does it fill?

Here now, it seems that we use type names to check if a plugin has been added:
Image
But acturally, the type name is not a unique identifier in rust:
Image
So I think it is possible for different plugins to have the same type name. Once it happeded, our method above may lead to errors

## What solution would you like?

Maybe we can use the `TypeId` instead

## What alternative(s) have you considered?

...

## Additional context

...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.