bevyengine / bevyengine/bevy

Don't automatically derive BundleFromComponents with Bundle

Open
#19,560 5 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Usability D-Macros D-Straightforward M-Migration-Guide S-Needs-Design X-Contentious
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

Instead of making `BundleFromComponents` opt-out, though, would it make sense to have it be opt-in and require `#[derive(Bundle, BundleFromComponents)]`? That better matches the general convention that a derive only implements a single trait. And if you do need to call `take`, the trait bound should help guide you to derive the second trait.

_Originally posted by @chescock in https://github.com/bevyengine/bevy/pull/19249#pullrequestreview-2893490671_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.