bevyengine / bevyengine/bevy

Support normal maps when no tangents exist

Open
#19,069 0 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Feature D-Modest S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

## What problem does this solve or what need does it fill?

When adding a material with a normal map to a mesh without tangents, Bevy will silently ignore the normal map

## What solution would you like?

Per @DGriffin91

> It would be nice to be able to fallback to screen space generated tangets here in the fragment shader, I think the code for this already exists on the meshlet path but could be used here too.

## What alternative(s) have you considered?

Warn the user least in this scenario

## Additional context

I ran into this and debugging took quite a while, as I expected my normal maps to be the problem. Nope, the tangents on the mesh were missing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.