bevyengine / bevyengine/bevy

Experiment with optmizing insert_children

Open
#18,687 0 comments 0 reactions 0 assignees View on GitHub
A-ECS C-Performance D-Straightforward S-Needs-Benchmarking S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

Can we let the user pass a `Vec` or `Box<[Entity]>` here instead? I think 9 times out of 10, the caller will be building a `Vec` or something already. I would prefer the caller make the allocation explicitly if they need to.

Maybe take a `impl AsRef<[Entity]> + 'static` instead?

_Originally posted by @ElliottjPierce in https://github.com/bevyengine/bevy/pull/18675#discussion_r2024982419_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.