bevyengine / bevyengine/bevy

Redo #17581, removing bevy_pbr dependency in bevy_gizmos

Open
#18,343 1 comment 0 reactions 0 assignees View on GitHub
A-Rendering C-Code-Quality D-Straightforward S-Ready-For-Implementation X-Uncontroversial
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

> Uh, I'm not sure that PR was the issue? I mean, yes it broke gizmos when it was merged, but when it was created it didn't break like that. I think it might have been an issue with the merge to main but the original PR was correct.

Yup, main probably changed something between the time it was opened and when it was merged, so it should be redone for current main

_Originally posted by @mockersf in https://github.com/bevyengine/bevy/issues/18327#issuecomment-2726891161_

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #17581 and the referenced discussion in #18327, then inspect the current dependency setup for bevy_gizmos and bevy_pbr on main. Reproduce the gizmo breakage against current main and compare the earlier change. Done means bevy_gizmos no longer depends on bevy_pbr while gizmo behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.