Revisit Queued Component Registration code quality after Component as Entities
- Dominant language
- Rust
- Stars
- 48.2k
- Forks
- 4.8k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 161
Description
> But what you have seems fine to start with! I imagine it will have to be reworked for components-as-entities anyway. I do hope we eventually get to something that's clear enough not to require quite so many lines of comments, though :).
100% Agree. Your comments here are valid, I just think compressing the safety to right here is less complicated than having to think about "What if this registration was queued in this particular way?" though out `Components`, even though that does make this particular function very non-trivial. But that's just my opinion.
IIUC, this part of Bevy is going to change a lot over 0.17. So I think we can revisit making this faster with `Vec` and `drain` later. It's certainly not a regression since queueing is new. If this is merged, I'll make an issue to track cleaning this up a bit once the dust settles.
_Originally posted by @ElliottjPierce in https://github.com/bevyengine/bevy/pull/18173#discussion_r1984380909_
This is a stub for now. After components as entities, we can revisit this. This issue is just to make sure we don't neglect or forget this.
Contributor guide
Assessment
This issue has not been assessed yet.