bevyengine / bevyengine/bevy

Add label and CI task to catch and document direct dependency changes

Open
#18,264 3 comments 0 reactions 0 assignees View on GitHub
A-Build-System C-Feature S-Ready-For-Implementation X-Blessed
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

## What problem does this solve or what need does it fill?

As noted by Cart in #18263, it is currently quite easy to add new direct dependencies to Bevy, which poses a performance, reliability, and security risk to the project and its users.

## What solution would you like?

- Add a new label, `M-Deliberate-Dependency-Change`, for PRs which intentionally add, remove, or update direct dependencies.
- Add a CI task which catches and comments on PRs which modify direct dependencies without this label.
- Update the contributing guide to indicate new dependencies must be highly trustworthy (known actor / high traffic / high visibility / high review)

## What alternative(s) have you considered?

Do nothing and continue to be careful.

## Additional context

[Thread on Discord](https://discord.com/channels/691052431525675048/692572690833473578/1349122559089704970)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.