bevyengine / bevyengine/bevy

Add additional benchmarks to `picking::ray_mesh_intersection`

Open
#18,254 0 comments 0 reactions 0 assignees View on GitHub
A-Picking C-Benchmarks D-Modest
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

In order to merge #18232 (originally #16148), the improvements to our benchmarks had to be reverted in order to avoid merge conflicts. These changes are still generally useful, however, and would improve our `picking` benchmarks if integrated.

Specifically, changes changes made to `ray_mesh_intersection.rs` [here](https://github.com/tbillington/bevy/blob/60b6c516fa09ddce0e73070b6fac682a150de4ff/benches/benches/bevy_picking/ray_mesh_intersection.rs) need to be combined with the changes made in #17033, which caused the merge conflict.

Contributor guide

Open the contributing guide

Research direction

Compare benches/benches/bevy_picking/ray_mesh_intersection.rs at the linked commit with its current version, then review the benchmark changes from #17033 and the context of #18232. Combine the still-useful benchmark improvements without reintroducing the merge conflict, and confirm the picking benchmarks build and run successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.