bevyengine / bevyengine/bevy

AnimationEvaluationError::ComponentNotPresent should take a ComponentId

Open
#17,776 0 comments 0 reactions 0 assignees View on GitHub
A-Animation C-Bug S-Needs-Design
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## Bevy version

0.15.2

## What you did

I'm currently trying to implement animations for a scripting system. This system may have dynamic components that don't have a TypeId, only a ComponentId.

## What went wrong

When returning the error `bevy::animation::AnimationEvaluationError::ComponentNotPresent(_)` from `AnimationCurveEvaluator::commit`, I have to supply a TypeId for a missing component, but that component might not have a TypeId, because it was created at runtime.

I think this should take a ComponentId instead.

Contributor guide

Open the contributing guide

Research direction

Start at AnimationEvaluationError::ComponentNotPresent and AnimationCurveEvaluator::commit, the entry points named in the issue. Trace how the missing component is identified, then verify that the error can represent runtime components without a TypeId and that existing animation evaluation error handling remains consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.