bevyengine / bevyengine/bevy

Consolidate view binding imports and positions

Open
#15,645 2 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Code-Quality C-Feature D-Straightforward S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## What problem does this solve or what need does it fill?

- consolidate view binding imports under `bevy_render`
- standardise shader view uniform bindings to group 0, binding 0
- consider standardising `globals` binding position to group 0, binding 1 and moving its import to `bevy_render`

See [cart's comment](https://github.com/bevyengine/bevy/pull/5535#issuecomment-1660948591) on now-closed 2022 PR #5535. Adopting the closed PR may provide a good starting point.

Contributor guide

Open the contributing guide

Research direction

Start with the now-closed PR #5535 and cart's linked comment for the prior approach. Trace the view-binding imports, shader view uniform bindings, and globals binding declarations across the relevant Bevy rendering code. Done means view binding imports are consolidated under bevy_render and the specified group and binding positions are standardized.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.