bevyengine / bevyengine/bevy

Swap most uses of allow in lints to expect

Open
#15,059 10 comments 1 reaction 1 assignee Claimed by @bas-ie View on GitHub
A-Cross-Cutting C-Code-Quality D-Straightforward S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 16h
Merged PRs (30d)
171

Description

## What problem does this solve or what need does it fill?

With the advent of [Rust 1.81](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html), we can now distinguish between lints that we haven't gotten around to fixing and those where the lint is wrong.

## What solution would you like?

Most localized lints in Bevy should be `expect`: the only exception that comes to mind is `missing_docs`.

Leave the `Cargo.toml` lints set as allow, as funny as it would be to set a crate-level `expect(type_complexity)`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.