bevyengine / bevyengine/bevy

Fog toggling shader flag is suboptimal

Open
#13,802 2 comments 0 reactions 0 assignees View on GitHub
A-Rendering C-Performance D-Shaders D-Straightforward S-Ready-For-Implementation
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

> This wasn't done the right way, I don't think. What I suggested was to make the `FOG_ENABLED` shader def contingent on whether the view has fog, not whether the material had a flag that disables it.

_Originally posted by @pcwalton in https://github.com/bevyengine/bevy/issues/13783#issuecomment-2159306477_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.