bevyengine / bevyengine/bevy

Investigate reusing `AudioSink`

Open
#13,651 0 comments 0 reactions 0 assignees View on GitHub
A-Audio C-Feature S-Needs-Design X-Contentious
Dominant language
Rust
Stars
48.2k
Forks
4.8k
Avg merge
3d 22h
Merged PRs (30d)
161

Description

> I don't know how keen to actually go forward with it I am, but I'll mention that rodio 0.18 includes the change I made to `SpatialSink`, which theoretically allows the current audio system to be restructured to reuse its audio sinks.

_Originally posted by @mweatherley in https://github.com/bevyengine/bevy/issues/13612#issuecomment-2143111704_

`rodio`'s `SpatialSink` can now be cleared after https://github.com/RustAudio/rodio/pull/548 was merged, which means now both `Sink` and `SpacialSink` support being re-used. It may be worth investigating whether this is worth implementing, or if we should just skip this and go straight to the `kira` migration.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.