bevyengine / bevyengine/bevy-website

Consider adding back djlint (html linter) rule H006 (`<img>` tags need height and width attributes)

Open
#1,104 1 comment 0 reactions 0 assignees View on GitHub
A-Build-System A-Meta C-Code Quality S-Needs-Design
Dominant language
JavaScript
Stars
249
Forks
450
Avg merge
16h 20m
Merged PRs (30d)
6

Description

> I disagree on the disabling of one of those linter rules (H006) since I left it in for a reason (it's considered best practice to define height and width attributes on tags consisting of the size of the image being used, or imo when we're dealing with template then base size desired for layout unless we have a way to get the size of each image. Otherwise the browser would have to reflow and repaint the page which is a minor performance cost to account for variable size which also looks ugly since it causes images to pop in out of nowhere iirc).

[TrialDragon (me)](https://discord.com/users/111248120981037056) on [Discord](https://discord.com/channels/691052431525675048/695741366520512563/1216867815022399518)

As far as I know, this info is up to date, but perhaps I'm wrong about all of this. Thoughts on re-adding this rule?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.