bepass-org / bepass-org/dnsutils

Cache not removing expired items

Open
#4 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
16
Forks
11
PR merge metrics
No merged PRs in 30d

Description

Shouldn't the [janitor](https://github.com/bepass-org/dnsutils/blob/main/internal/cache/cache.go#L118) call [`DeleteExpired`](https://github.com/bepass-org/dnsutils/blob/main/internal/cache/cache.go#L87) method? Currently expired items are always available. They never get cleaned, [janitor](https://github.com/bepass-org/dnsutils/blob/main/internal/cache/cache.go#L124) only calls `onExpired` callback. I think it should also call `DeleteExpired`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in internal/cache/cache.go at the janitor and DeleteExpired entry points linked in the issue. Confirm how the janitor handles expired items and ensure the completed behavior removes them so they are no longer available.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.