benoitc / benoitc/dnssd_erlang
Typos in a couple of conditions
- Dominant language
- Erlang
- Stars
- 46
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
```
c_src/dnssd.c:206:22: warning: comparison of constant 137 with boolean expression is always false [-Wtautological-constant-out-of-range-compare]
if (!arg.ei_type == ERL_TUPLE || arg.arity != 2) goto badarg;
~~~~~~~~~~~~ ^ ~~~~~~~~~
c_src/dnssd.c:235:22: warning: comparison of constant 137 with boolean expression is always false [-Wtautological-constant-out-of-range-compare]
if (!arg.ei_type == ERL_TUPLE || arg.arity != 3) goto badarg;
~~~~~~~~~~~~ ^ ~~~~~~~~~
c_src/dnssd.c:279:22: warning: comparison of constant 137 with boolean expression is always false [-Wtautological-constant-out-of-range-compare]
if (!arg.ei_type == ERL_TUPLE || arg.arity != 6) goto badarg;
~~~~~~~~~~~~ ^ ~~~~~~~~~
```
I believe you meant to say `if (arg.ei_type != ERL_TUPLE ...`.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.