benoitc / benoitc/couchdbkit

fetch_attachment does not consider '_rev_'

Open
#192 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
263
Forks
90
PR merge metrics
No merged PRs in 30d

Description

As far I can see (and test) fetch_attachment does not consider the _rev field when it is passed in the "doc".

This can cause problems: we are going to get always the latest document, avoiding any conflict.

Here my patch:

```
$ diff client.py ~/sources/couchdbkit-0.6.5/couchdbkit/client.py
855d854
< doc = {}
863c862
< resp = self.res(docid).get(name, headers=headers, rev=doc.get('_rev'))

---
> resp = self.res(docid).get(name, headers=headers)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.