benjamn / benjamn/reify

Live binding incomplete

Open
#180 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
740
Forks
29
PR merge metrics
No merged PRs in 30d

Description

In adding a unit test for modifying a constant value I noticed a gap.

##### const.js
```js
export const value = 1
```
##### test.js
```js
import { value } from "./const.js"

value = 2 // should throw
```
It should throw since `value` is a `const`, but currently reify doesn't track imported values, so doesn't wrap them in a setter call. *It also defines `value` with either `var` or `let` but that prolly doesn't matter as much because if it were wrapped in a setter call an error would get thrown in the `const` module.*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the import handling exercised by test.js and compare it with the const.js export shown in the report. Add a regression unit test for assigning to the imported value, then run the relevant test suite; done means the assignment throws as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.