benjamn / benjamn/recast

Ignore unrecognized fields when comparing AST nodes

Open Beginner friendly
#90 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
5.3k
Forks
363
Avg merge
3d 8h
Merged PRs (30d)
3

Description

This would help work around the problem identified here: https://github.com/benjamn/recast/issues/89#issuecomment-45261490

This is the line that probably needs to change to use `types.eachField`: https://github.com/benjamn/recast/blob/547947e20036a18a46ea140680f866772872070d/lib/patcher.js#L292

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at lib/patcher.js around line 292, then inspect the issue 89 comment and the available types.eachField helper. Confirm how AST nodes are currently compared and verify that the issue 89 scenario succeeds once unrecognized fields are ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers, devtools
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.