benjamn / benjamn/recast

Upgrading from 14.1.0 to 14.2.0 json no longer parsed

Open
#488 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5.3k
Forks
363
Avg merge
3d 8h
Merged PRs (30d)
3

Description

this used to parse fine and make it through recast

```
const x =
{"foo":"💃"}
```

upgrading to 14.2.0 causes:

```
console.error bin/main.js:134
Error processing x/bar.json
console.error bin/main.js:135
Cannot find module 'esprima' from 'utils.js'
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with utils.js and the error path reported at bin/main.js:134-135, then compare JSON handling between recast 14.1.0 and 14.2.0. Reproduce the const x example and verify that the JSON is parsed and processed without the missing esprima error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.