benjamn / benjamn/recast

Don't recognize trailing comments that are separated from the node by more than one line

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
5.3k
Forks
363
Avg merge
3d 8h
Merged PRs (30d)
3

Description

For example, we currently consider the indented comment below to be a trailing comment for `a();`, because it is indented more deeply than the `b();` node:

``` js
a(); // trailing comment for a()

// oddly indented comment that should lead b() rather than trailing a()
b();
```

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is named. Start by reproducing the JavaScript example and trace the logic that associates comments with adjacent nodes. Done means the separated, oddly indented comment leads b(); rather than being treated as trailing a(), with a regression test covering the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.