benjamn / benjamn/ast-types

VariableDeclaration builder params order

Open
#88 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.2k
Forks
194
Avg merge
22h 43m
Merged PRs (30d)
10

Description

In the [definition of VariableDeclaration](https://github.com/benjamn/ast-types/blob/master/def/core.js#L182) you have the first `kind` param and the second `declarations`, whereas [spec](https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API#Declarations) describes `declarations` as first and then `kind`. Esprima also prints `kind` as the last param, thogh it doesn’t matter as far it is object.
Is there some reason to keep exactly that order of params in builder?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the VariableDeclaration definition in def/core.js at the linked line, then compare its builder parameter order with the Mozilla parser API and Esprima references in the issue. Done means determining whether the order should change or be retained and documenting or implementing the agreed result.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.