benjamn / benjamn/ast-types

passing along source location when building nodes

Open
#23 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.2k
Forks
194
Avg merge
22h 43m
Merged PRs (30d)
10

Description

The problem I had before was due to transformations not keeping the source locations in the final nodes. There are a few key places that need to copy along the source locs.

What's the right pattern to do this with builders? Do I need to assign the node to a variable and then do something like `newNode.loc = oldNode.loc`? Or can I pass along the source locations to the builders somehow?

Contributor guide

No contributing guide indexed for this repository

Research direction

Trace the transformations and builders that create the final nodes, then inspect how source locations are currently represented and preserved. Determine the intended builder pattern for carrying source locations through transformations; the work is done when the approach is defined and the affected transformations consistently retain their source locations.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.