benjamn / benjamn/ast-types

esprima def should contain ExportNamedDeclaration and ExportDefaultDeclaration

Open
#180 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.2k
Forks
194
Avg merge
22h 43m
Merged PRs (30d)
10

Description

The esprima def recognizes `ExportDeclaration`, which AFAICT was from the `harmony` branch of esprima which is abandoned, and esprima (and estree) now uses `ExportNamedDeclaration` and `ExportDefaultDeclaration`.

https://github.com/jquery/esprima/pull/1149

these defs are in babel.js but should also be in esprima.js, or I guess in es6.js.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the definitions in babel.js with esprima.js and es6.js, focusing on the missing ExportNamedDeclaration and ExportDefaultDeclaration entries. Confirm which file should contain the definitions, then update the appropriate definition file so it matches the current Esprima and ESTree names.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.